KAC command ban length

[Deceiver]

Hi, thanks for this great script, i appreciate it a lot.

I would however like to change the ban time for commands like physics_budget and changelevel (all of the ones in the commands.sp that will ban you) to 1 day, so i went to commands.sp file and changed the lines

Code: Select all

KAC_Ban(client, 0, KAC_CBANNED, "KAC: Command %s violation", f_sCmd);

to

Code: Select all

KAC_Ban(client, 1440, KAC_CBANNED, "KAC: Command %s violation", f_sCmd);

I restarted the server and its still a perm ban. Is there something else i need to change? have i changed the wrong thing?

Thanks in advance.

(Also the buttons like Code, list, Img etc dont work on this forum, is it just me?)

[Kigen]

There are two lines like that in KAC 1.2.0. One is for the old style of hooking commands and then there is another for the new style for SM 1.3 and newer.

[Deceiver]

So how do i change the length of the ban?

[Kigen]

There isn't any official way to change the time, though you can alter the code like you've been doing, just look for a second line like the one that you already found.

I plan to redo this system to be better.

[Deceiver]

i did do that, unless im missing something. do i need to change anything else other than commands.sp?

this is what i have

Code: Select all

/*
    Kigen's Anti-Cheat Commands Module
    Copyright (C) 2007-2010 Max Krivanek

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/

#define COMMANDS

//- Global Variables -//
new Handle:g_hBlockedCmds = INVALID_HANDLE;
new bool:g_bCmdEnabled = true;
new bool:g_bLogCmds = false;
new g_iCmdSpam = 10;
new g_iCmdCount[MAXPLAYERS+2] = {0, ...};
new Handle:g_hCountReset = INVALID_HANDLE;
new Handle:g_hCVarCmdEnable = INVALID_HANDLE;
new Handle:g_hCVarCmdSpam = INVALID_HANDLE;
new Handle:g_hCVarCmdLog = INVALID_HANDLE;
new String:g_sCmdLogPath[256];
new g_iCmdStatus;
new g_iCmdSpamStatus;

//- Plugin Functions -//

Commands_OnPluginStart()
{
	g_hCVarCmdEnable = FindConVar("kac_cmds_enable");
	if ( g_hCVarCmdEnable == INVALID_HANDLE )
		g_hCVarCmdEnable = CreateConVar("kac_cmds_enable", "1", "If the Commands Module of KAC is enabled.");
	else
		g_bCmdEnabled = GetConVarBool(g_hCVarCmdEnable);

	g_hCVarCmdSpam = FindConVar("kac_cmds_spam");
	if ( g_hCVarCmdSpam == INVALID_HANDLE )
		g_hCVarCmdSpam = CreateConVar("kac_cmds_spam", "10", "Amount of commands in one second before kick.  0 for disable.");
	else
		g_iCmdSpam = GetConVarInt(g_hCVarCmdSpam);

	g_hCVarCmdLog = FindConVar("kac_cmds_log");
	if ( g_hCVarCmdLog == INVALID_HANDLE )
		g_hCVarCmdLog = CreateConVar("kac_cmds_log", "0", "Log command usage.  Use only for debugging purposes.");
	else
		g_bLogCmds = GetConVarBool(g_hCVarCmdLog);

	HookConVarChange(g_hCVarCmdEnable, Commands_CmdEnableChange);
	HookConVarChange(g_hCVarCmdSpam, Commands_CmdSpamChange);
	HookConVarChange(g_hCVarCmdLog, Commands_CmdLogChange);

//- Setup logging path -//
	for(new i=0;;i++)
	{
		BuildPath(Path_SM, g_sCmdLogPath, sizeof(g_sCmdLogPath), "logs/KACCmdLog_%d.log", i);
		if ( !FileExists(g_sCmdLogPath) )
			break;
	}

	if ( g_bCmdEnabled )
	{
		g_iCmdStatus = Status_Register(KAC_CMDMOD, KAC_ON);
		if ( !g_iCmdSpam )
			g_iCmdSpamStatus = Status_Register(KAC_CMDSPAM, KAC_OFF);
		else
			g_iCmdSpamStatus = Status_Register(KAC_CMDSPAM, KAC_ON);
	}
	else
	{
		g_iCmdStatus = Status_Register(KAC_CMDMOD, KAC_OFF);
		g_iCmdSpamStatus = Status_Register(KAC_CMDSPAM, KAC_DISABLED);
	}

	RegConsoleCmd("say", Commands_FilterSay);
	RegConsoleCmd("say_team", Commands_FilterSay);
}

Commands_OnAllPluginsLoaded()
{
	decl Handle:f_hConCommand, String:f_sName[64], bool:f_bIsCommand, f_iFlags;

	g_hBlockedCmds = CreateTrie();

	// Exploitable needed commands.  Sigh....
	RegConsoleCmd("ent_create", Commands_BlockEntExploit);
	RegConsoleCmd("ent_fire", Commands_BlockEntExploit);

	//- Blocked Commands -// Note: True sets them to ban, false does not.
	SetTrieValue(g_hBlockedCmds, "ai_test_los", 			true);
	SetTrieValue(g_hBlockedCmds, "changelevel", 			true);
	SetTrieValue(g_hBlockedCmds, "cl_fullupdate",			false);
	SetTrieValue(g_hBlockedCmds, "dbghist_addline", 		false);
	SetTrieValue(g_hBlockedCmds, "dbghist_dump", 			true);
	SetTrieValue(g_hBlockedCmds, "drawcross",			true);
	SetTrieValue(g_hBlockedCmds, "drawline",			true);
	SetTrieValue(g_hBlockedCmds, "dump_entity_sizes", 		true);
	SetTrieValue(g_hBlockedCmds, "dump_globals", 			true);
	SetTrieValue(g_hBlockedCmds, "dump_panels", 			true);
	SetTrieValue(g_hBlockedCmds, "dump_terrain", 			true);
	SetTrieValue(g_hBlockedCmds, "dumpcountedstrings", 		true);
	SetTrieValue(g_hBlockedCmds, "dumpentityfactories", 		true);
	SetTrieValue(g_hBlockedCmds, "dumpeventqueue", 			true);
	SetTrieValue(g_hBlockedCmds, "dumpgamestringtable", 		false);
	SetTrieValue(g_hBlockedCmds, "editdemo", 			true);
	SetTrieValue(g_hBlockedCmds, "endround", 			true);
	SetTrieValue(g_hBlockedCmds, "groundlist", 			true);
	SetTrieValue(g_hBlockedCmds, "listmodels", 			true);
	SetTrieValue(g_hBlockedCmds, "map_showspawnpoints",		false);
	SetTrieValue(g_hBlockedCmds, "mem_dump", 			true);
	SetTrieValue(g_hBlockedCmds, "mp_dump_timers", 			true);
	SetTrieValue(g_hBlockedCmds, "npc_ammo_deplete", 		false);
	SetTrieValue(g_hBlockedCmds, "npc_heal", 			false);
	SetTrieValue(g_hBlockedCmds, "npc_speakall", 			false);
	SetTrieValue(g_hBlockedCmds, "npc_thinknow", 			false);
	SetTrieValue(g_hBlockedCmds, "physics_budget",			true);
	SetTrieValue(g_hBlockedCmds, "physics_debug_entity", 		true);
	SetTrieValue(g_hBlockedCmds, "physics_highlight_active", 	false);
	SetTrieValue(g_hBlockedCmds, "physics_report_active", 		true);
	SetTrieValue(g_hBlockedCmds, "physics_select", 			true);
	SetTrieValue(g_hBlockedCmds, "q_sndrcn", 			true);
	SetTrieValue(g_hBlockedCmds, "scene_flush", 			true);
	SetTrieValue(g_hBlockedCmds, "send_me_rcon", 			true);
	SetTrieValue(g_hBlockedCmds, "snd_restart", 			false);
	SetTrieValue(g_hBlockedCmds, "soundlist", 			true);
	SetTrieValue(g_hBlockedCmds, "soundscape_flush", 		false);
	SetTrieValue(g_hBlockedCmds, "sv_benchmark_force_start", 	true);
	SetTrieValue(g_hBlockedCmds, "sv_findsoundname", 		true);
	SetTrieValue(g_hBlockedCmds, "sv_soundemitter_filecheck", 	true);
	SetTrieValue(g_hBlockedCmds, "sv_soundemitter_flush", 		true);
	SetTrieValue(g_hBlockedCmds, "sv_soundscape_printdebuginfo", 	true);
	SetTrieValue(g_hBlockedCmds, "report_entities", 		true);
	SetTrieValue(g_hBlockedCmds, "report_touchlinks", 		true);
	SetTrieValue(g_hBlockedCmds, "report_simthinklist", 		true);
	SetTrieValue(g_hBlockedCmds, "rr_reloadresponsesystems", 	true);
	SetTrieValue(g_hBlockedCmds, "wc_update_entity", 		false);

	if ( g_bCmdEnabled )
		g_hCountReset = CreateTimer(1.0, Commands_CountReset, _, TIMER_REPEAT);
	else
		g_hCountReset = INVALID_HANDLE;

	if ( !g_bIsNewSM || GetFeatureStatus(FeatureType_Capability, FEATURECAP_COMMANDLISTENER) != FeatureStatus_Available || !AddCommandListener(Commands_CommandListener) )
	{
		f_hConCommand = FindFirstConCommand(f_sName, sizeof(f_sName), f_bIsCommand, f_iFlags);
		if ( f_hConCommand == INVALID_HANDLE )
			SetFailState("Failed getting first ConCommand");

		do
		{
			if ( !f_bIsCommand || StrEqual(f_sName, "sm") )
				continue;
			if ( StrEqual(f_sName, "buy") || StrEqual(f_sName, "use") || StrContains(f_sName, "es_") != -1 )
				RegConsoleCmd(f_sName, Commands_ClientCheck);
			else
				RegConsoleCmd(f_sName, Commands_SpamCheck);
		} while ( FindNextConCommand(f_hConCommand, f_sName, sizeof(f_sName), f_bIsCommand, f_iFlags));

		CloseHandle(f_hConCommand);
	}

	RegAdminCmd("kac_addcmd", 	Commands_AddCmd, 	ADMFLAG_ROOT, 	"Adds a command to be blocked by KAC.");
	RegAdminCmd("kac_removecmd", 	Commands_RemoveCmd, 	ADMFLAG_ROOT, 	"Removes a command from the block list.");
}

Commands_OnPluginEnd()
{
	if ( g_hCountReset != INVALID_HANDLE )
		CloseHandle(g_hCountReset);
}

//- Admin Commnads -//

public Action:Commands_AddCmd(client, args)
{
	if ( args != 2 )
	{
		KAC_ReplyToCommand(client, KAC_ADDCMDUSAGE);
		return Plugin_Handled;
	}

	decl String:f_sCmdName[64], String:f_sTemp[8], bool:f_bBan;
	GetCmdArg(1, f_sCmdName, sizeof(f_sCmdName));

	GetCmdArg(2, f_sTemp, sizeof(f_sTemp));
	if ( StringToInt(f_sTemp) != 0 || StrEqual(f_sTemp, "ban") || StrEqual(f_sTemp, "yes") || StrEqual(f_sTemp, "true") )
		f_bBan = true;
	else
		f_bBan = false;

	if ( SetTrieValue(g_hBlockedCmds, f_sCmdName, f_bBan) )
		KAC_ReplyToCommand(client, KAC_ADDCMDSUCCESS, f_sCmdName);
	else
		KAC_ReplyToCommand(client, KAC_ADDCMDFAILURE, f_sCmdName);
	return Plugin_Handled;
}

public Action:Commands_RemoveCmd(client, args)
{
	if ( args != 1 )
	{
		KAC_ReplyToCommand(client, KAC_REMCMDUSAGE);
		return Plugin_Handled;
	}

	decl String:f_sCmdName[64];
	GetCmdArg(1, f_sCmdName, sizeof(f_sCmdName));

	if ( RemoveFromTrie(g_hBlockedCmds, f_sCmdName) )
		KAC_ReplyToCommand(client, KAC_REMCMDSUCCESS, f_sCmdName);
	else
		KAC_ReplyToCommand(client, KAC_REMCMDFAILURE, f_sCmdName);
	return Plugin_Handled;
}

//- Console Commands -//

public Action:Commands_FilterSay(client, args)
{
	if ( !g_bCmdEnabled )
		return Plugin_Continue;

	decl String:f_sMsg[256], f_iLen, String:f_cChar;
	GetCmdArgString(f_sMsg, sizeof(f_sMsg));
	f_iLen = strlen(f_sMsg);
	for(new i=0;i<f_iLen;i++)
	{
		f_cChar = f_sMsg[i];
		if ( f_cChar < 32 && !IsCharMB(f_cChar) )
		{
			KAC_ReplyToCommand(client, KAC_SAYBLOCK);
			return Plugin_Stop;
		}
	}
	return Plugin_Continue;
}

public Action:Commands_BlockEntExploit(client, args)
{
	if ( !client )
		return Plugin_Continue;
	if ( !g_bInGame[client] )
		return Plugin_Stop;
	if ( !g_bCmdEnabled )
		return Plugin_Continue;
	
	decl String:f_sCmd[512];
	GetCmdArgString(f_sCmd, sizeof(f_sCmd));
	if ( strlen(f_sCmd) > 500 )
		return Plugin_Stop; // Too long to process.
	if ( StrContains(f_sCmd, "point_servercommand") != -1 	|| StrContains(f_sCmd, "point_clientcommand") != -1 
	  || StrContains(f_sCmd, "logic_timer") != -1 	   	|| StrContains(f_sCmd, "quit") != -1
	  || StrContains(f_sCmd, "sm") != -1 		   	|| StrContains(f_sCmd, "quti") != -1 
	  || StrContains(f_sCmd, "restart") != -1 		|| StrContains(f_sCmd, "alias") != -1
	  || StrContains(f_sCmd, "admin") != -1 		|| StrContains(f_sCmd, "ma_") != -1 
	  || StrContains(f_sCmd, "rcon") != -1 			|| StrContains(f_sCmd, "sv_") != -1 
	  || StrContains(f_sCmd, "mp_") != -1 			|| StrContains(f_sCmd, "meta") != -1 
	  || StrContains(f_sCmd, "taketimer") != -1 )
	{
		if ( g_bLogCmds )
		{
			decl String:f_sCmdName[64];
			GetCmdArg(0, f_sCmdName, sizeof(f_sCmdName));
			LogToFileEx(g_sCmdLogPath, "%L attempted command: %s %s", client, f_sCmdName, f_sCmd);
		}
		return Plugin_Stop;
	}
	return Plugin_Continue;
}

public Action:Commands_CommandListener(client, const String:command[], argc)
{
	if ( !client )
		return Plugin_Continue;
	if ( !g_bInGame[client] )
		return Plugin_Stop;
	if ( !g_bCmdEnabled )
		return Plugin_Continue;
	
	decl bool:f_bBan;

	if ( GetTrieValue(g_hBlockedCmds, command, f_bBan) )
	{
		if ( f_bBan )
		{
			new String:f_sName[64], String:f_sAuthID[64], String:f_sIP[64], String:f_sCmdString[256];
			GetClientName(client, f_sName, sizeof(f_sName));
			GetClientAuthString(client, f_sAuthID, sizeof(f_sAuthID));
			GetClientIP(client, f_sIP, sizeof(f_sIP));
			GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
			KAC_Log("%s (ID: %s | IP: %s) was banned for command usage violation of command: %s %s", f_sName, f_sAuthID, f_sIP, command, f_sCmdString);
			KAC_Ban(client, 1440, KAC_CBANNED, "KAC: Command %s violation", command);
		}
		return Plugin_Stop;
	}

	if ( g_bLogCmds )
	{
		decl String:f_sCmdString[256];
		GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
		LogToFileEx(g_sCmdLogPath, "%L used command: %s %s", client, command, f_sCmdString);
	}

	if ( g_iCmdSpam != 0 && !StrEqual(command, "buy") && !StrEqual(command, "use") && !StrEqual(command, "buyammo1") && !StrEqual(command, "buyammo2") && StrContains(command, "es_") == -1 && g_iCmdCount[client]++ > g_iCmdSpam )
	{
		decl String:f_sName[64], String:f_sAuthID[64], String:f_sIP[64], String:f_sCmdString[128];
		GetClientName(client, f_sName, sizeof(f_sName));
		GetClientAuthString(client, f_sAuthID, sizeof(f_sAuthID));
		GetClientIP(client, f_sIP, sizeof(f_sIP));
		GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
		KAC_Log("%s (ID: %s | IP: %s) was kicked for command spamming: %s %s", f_sName, f_sAuthID, f_sIP, command, f_sCmdString);
		KAC_Kick(client, KAC_KCMDSPAM);
		return Plugin_Stop;
	}

	return Plugin_Continue;
}

public Action:Commands_ClientCheck(client, args)
{
	if ( !client )
		return Plugin_Continue;
	if ( !g_bInGame[client] )
		return Plugin_Stop;
	if ( !g_bCmdEnabled )
		return Plugin_Continue;

	decl String:f_sCmd[64], bool:f_bBan;
	GetCmdArg(0, f_sCmd, sizeof(f_sCmd));
	StringToLower(f_sCmd);

	if ( GetTrieValue(g_hBlockedCmds, f_sCmd, f_bBan) )
	{
		if ( f_bBan )
		{
			new String:f_sName[64], String:f_sAuthID[64], String:f_sIP[64], String:f_sCmdString[256];
			GetClientName(client, f_sName, sizeof(f_sName));
			GetClientAuthString(client, f_sAuthID, sizeof(f_sAuthID));
			GetClientIP(client, f_sIP, sizeof(f_sIP));
			GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
			KAC_Log("%s (ID: %s | IP: %s) was banned for command usage violation of command: %s %s", f_sName, f_sAuthID, f_sIP, f_sCmd, f_sCmdString);
			KAC_Ban(client, 1440, KAC_CBANNED, "KAC: Command %s violation", f_sCmd);
		}
		return Plugin_Stop;
	}

	if ( g_bLogCmds )
	{
		decl String:f_sCmdString[256];
		GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
		LogToFileEx(g_sCmdLogPath, "%L used command: %s %s", client, f_sCmd, f_sCmdString);
	}

	return Plugin_Continue;
}

public Action:Commands_SpamCheck(client, args)
{
	if ( !client )
		return Plugin_Continue;
	if ( !g_bInGame[client] )
		return Plugin_Stop;
	if ( !g_bCmdEnabled )
		return Plugin_Continue;

	decl bool:f_bBan, String:f_sCmd[64];
	GetCmdArg(0, f_sCmd, sizeof(f_sCmd)); // This command's name.
	StringToLower(f_sCmd);

	if ( g_iCmdSpam != 0 && g_iCmdCount[client]++ > g_iCmdSpam )
	{
		decl String:f_sName[64], String:f_sAuthID[64], String:f_sIP[64], String:f_sCmdString[128];
		GetClientName(client, f_sName, sizeof(f_sName));
		GetClientAuthString(client, f_sAuthID, sizeof(f_sAuthID));
		GetClientIP(client, f_sIP, sizeof(f_sIP));
		GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
		KAC_Log("%s (ID: %s | IP: %s) was kicked for command spamming: %s %s", f_sName, f_sAuthID, f_sIP, f_sCmd, f_sCmdString);
		KAC_Kick(client, KAC_KCMDSPAM);
		return Plugin_Stop;
	}

	if ( GetTrieValue(g_hBlockedCmds, f_sCmd, f_bBan) )
	{
		if ( f_bBan )
		{
			new String:f_sName[64], String:f_sAuthID[64], String:f_sIP[64], String:f_sCmdString[256];
			GetClientName(client, f_sName, sizeof(f_sName));
			GetClientAuthString(client, f_sAuthID, sizeof(f_sAuthID));
			GetClientIP(client, f_sIP, sizeof(f_sIP));
			GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
			KAC_Log("%s (ID: %s | IP: %s) was banned for command usage violation of command: %s %s", f_sName, f_sAuthID, f_sIP, f_sCmd, f_sCmdString);
			KAC_Ban(client, 1440, KAC_CBANNED, "KAC: Command %s violation", f_sCmd);
		}
		return Plugin_Stop;
	}

	if ( g_bLogCmds )
	{
		decl String:f_sCmdString[256];
		GetCmdArgString(f_sCmdString, sizeof(f_sCmdString));
		LogToFileEx(g_sCmdLogPath, "%L used command: %s %s", client, f_sCmd, f_sCmdString);
	}

	return Plugin_Continue;
}

//- Timers -//

public Action:Commands_CountReset(Handle:timer, any:args)
{
	if ( !g_bCmdEnabled )
	{
		g_hCountReset = INVALID_HANDLE;
		return Plugin_Stop;
	}
	for(new i=1;i<=MaxClients;i++)
		g_iCmdCount[i] = 0;
	return Plugin_Continue;
}

//- Hooks -//

public Commands_CmdEnableChange(Handle:convar, const String:oldValue[], const String:newValue[])
{
	new bool:f_bEnabled = GetConVarBool(convar);
	if ( f_bEnabled == g_bCmdEnabled )
		return;

	if ( f_bEnabled )
	{
		if ( g_hCountReset == INVALID_HANDLE )
			g_hCountReset = CreateTimer(1.0, Commands_CountReset, _, TIMER_REPEAT);
		g_bCmdEnabled = true;
		g_iCmdStatus = Status_Register(KAC_CMDMOD, KAC_ON);
		if ( !g_iCmdSpam )
			g_iCmdSpamStatus = Status_Register(KAC_CMDSPAM, KAC_OFF);
		else
			g_iCmdSpamStatus = Status_Register(KAC_CMDSPAM, KAC_ON);
	}
	else if ( !f_bEnabled  )
	{
		if ( g_hCountReset != INVALID_HANDLE )
			CloseHandle(g_hCountReset);
		g_hCountReset = INVALID_HANDLE;
		g_bCmdEnabled = false;
		Status_Report(g_iCmdStatus, KAC_OFF);
		Status_Report(g_iCmdSpamStatus, KAC_DISABLED);
	}
}

public Commands_CmdSpamChange(Handle:convar, const String:oldValue[], const String:newValue[])
{
	g_iCmdSpam = GetConVarInt(convar);
	if ( !g_bCmdEnabled )
		Status_Report(g_iCmdSpamStatus, KAC_DISABLED);
	else if ( !g_iCmdSpam )
		Status_Report(g_iCmdSpamStatus, KAC_OFF);
	else
		Status_Report(g_iCmdSpamStatus, KAC_ON);
}

public Commands_CmdLogChange(Handle:convar, const String:oldValue[], const String:newValue[])
{
	g_bLogCmds = GetConVarBool(convar);
}

//- Private -//

stock StringToLower(String:f_sInput[])
{
	new f_iSize = strlen(f_sInput);
	for(new i=0;i<f_iSize;i++)
		f_sInput[i] = CharToLower(f_sInput[i]);
}

//- End of File -//

[Kigen]

The KAC_Ban() function is the only place where time is specified. Everything looks alright.

[Deceiver]

Then i don't understand why its still doing perm ban.

[Kigen]

You make sure that you are deleting old compiled files before re-compiling?

[Deceiver]

Yeah, it was me being stupid. Thanks for your help!

[Kigen]

Changes to any script files in the "kigenac" folder are not detected by the compiler. So you have to delete the old compiled file to make SourcePAWN compiler recompile the script.